Open
Conversation
* Minor tweaks to Formatting * Added a section about contribution * Added section about how to test * Added a few words about present and future organization
* Left all existing code in place * Created two new functions to make more modular and easier to test * Moved a few lines of existing code into those two new functions
Updated internal calculations to track both lines added and removed while matching the original contribution and churn calculations Additionally, file change counts were manually reviewed to ensure their correctness.
* Refactored existing code to track line add and line removal * Made sure the code remained true to original churn and contributions counts
vvaishakh1
reviewed
Aug 22, 2022
| # https://stackoverflow.com/a/21079437 | ||
| command += ' -- . ":(exclude,icase)'+exdir+'"' | ||
| results = get_proc_out(command, dir).splitlines() | ||
| results = get_commit_results(command, dir) |
There was a problem hiding this comment.
@NewMountain I guess this method definition is missing..
Author
There was a problem hiding this comment.
I'm not sure how I missed this 🤦 . Let me get this sorted out and update.
Author
|
@vvaishakh1 @olleharstedt . Forgot a function. Added that in. Everything passes on my end. I apologize for the confusion. |
Scoppio
reviewed
Sep 2, 2024
| import argparse | ||
| import datetime | ||
| import os | ||
| import shlex |
There was a problem hiding this comment.
apparently shlex is not used in the project anywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes internal data structure of
filesto track the lines added/removed per line in files and a command line argument to optionally pretty-print the result.Leverages the test suite added in PR 15.
This PR will satisfy issues 16 and 13